Skip to content

Conversation

@jr
Copy link
Collaborator

@jr jr commented Jun 23, 2025

2 problems working together:

  1. Trying to fetch org settings at attempting-session instead of active-session.
  2. Not bubbling up org settings fetch failures properly to RefreshTimer, so we wait 30s instead of 1s (with backoff) to fetch after a failure.

Important

Fixes timing and error handling for fetching organization settings in SettingsService.ts.

  • Behavior:
    • Change event listener in SettingsService to start RefreshTimer on active-session instead of attempting-session.
    • Modify fetchSettings() to return a boolean indicating success or failure, affecting backoff logic in RefreshTimer.
  • Error Handling:
    • Ensure fetchSettings() returns false on failure to fetch or parse settings, improving retry logic.
  • Misc:
    • Remove unused attempting-session event listener in SettingsService.

This description was created by Ellipsis for c7dafc6. You can customize this summary. It will automatically update as commits are pushed.

@jr jr requested review from cte and mrubens as code owners June 23, 2025 18:44
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 23, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 23, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 23, 2025
@mrubens mrubens merged commit 9b40829 into main Jun 23, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 23, 2025
@mrubens mrubens deleted the jr/fetch-settings-only-when-ready branch June 23, 2025 18:47
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 23, 2025
cte pushed a commit that referenced this pull request Jun 24, 2025
Alorse pushed a commit to Alorse/Roo-Code that referenced this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants